Re: [Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

On 2016-03-25 14:20, Ilia Mirkin wrote: Instead of introducing buggy code in patch 6/17 and then fixing it up here, you need to fold this with patch 6 so that it's all done at the same time. Yea, can do. Cheers, On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan

Re: [Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

Instead of introducing buggy code in patch 6/17 and then fixing it up here, you need to fold this with patch 6 so that it's all done at the same time. On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: > Upon context creation, internal driver structures are

[Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

Upon context creation, internal driver structures are malloc()'ed and memset() to zero them. This results in a invalid number of samples 'by default'. Handle this in the simplest way to avoid elaborate and probably equally sub-optimial solutions. V2: Minor, use "NOTE:" instead of "N.B." in