Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

2017-10-18 Thread Jason Ekstrand
On Wed, Oct 18, 2017 at 6:11 AM, Eero Tamminen wrote: > Hi Jason, > > This commit dropped SynMark2 v7 OglShMapPcf performance by 1-2% on GT2 > versions of SKL, KBL and CFL. It may have improved it by same amount on > SKL GT4e. Effects on other machines were within normal variation. > That's ver

Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

2017-10-18 Thread Eero Tamminen
Hi Jason, This commit dropped SynMark2 v7 OglShMapPcf performance by 1-2% on GT2 versions of SKL, KBL and CFL. It may have improved it by same amount on SKL GT4e. Effects on other machines were within normal variation. - Eero On 30.09.2017 00:25, Jason Ekstrand wrote: Otherwise, i

Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

2017-10-06 Thread Jason Ekstrand
On Wed, Oct 4, 2017 at 7:31 PM, Jordan Justen wrote: > On 2017-09-29 14:25:10, Jason Ekstrand wrote: > > Otherwise, in the ARB program case _mesa_add_state_reference may grow > > the parameter array which will cause brw_nir_setup_arb_uniforms to write > > past the end of the param array because i

Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

2017-10-04 Thread Jordan Justen
On 2017-09-29 14:25:10, Jason Ekstrand wrote: > Otherwise, in the ARB program case _mesa_add_state_reference may grow > the parameter array which will cause brw_nir_setup_arb_uniforms to write > past the end of the param array because it only looks at the parameter > list length but the parma array

[Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

2017-09-29 Thread Jason Ekstrand
Otherwise, in the ARB program case _mesa_add_state_reference may grow the parameter array which will cause brw_nir_setup_arb_uniforms to write past the end of the param array because it only looks at the parameter list length but the parma array is allocated based on nir->num_uniforms. The only rea