Re: [Mesa-dev] [PATCH 10/21] nir/dominance: Handle unreachable blocks

2016-03-19 Thread Jason Ekstrand
On Wed, Feb 24, 2016 at 10:02 PM, Connor Abbott wrote: > I believe this is correct, and won't cause any issues with phi node > placement, etc. before dead_cf comes and gets rid any code in the > unreachable block(s). > > Reviewed-by: Connor Abbott > > BTW, I'd ask that you hold off on pushing th

Re: [Mesa-dev] [PATCH 10/21] nir/dominance: Handle unreachable blocks

2016-02-24 Thread Connor Abbott
I believe this is correct, and won't cause any issues with phi node placement, etc. before dead_cf comes and gets rid any code in the unreachable block(s). Reviewed-by: Connor Abbott BTW, I'd ask that you hold off on pushing this until I at least get a chance to look at the phi builder stuff. I'

[Mesa-dev] [PATCH 10/21] nir/dominance: Handle unreachable blocks

2016-02-13 Thread Jason Ekstrand
Previously, nir_dominance.c didn't properly handle unreachable blocks. This can happen if, for instance, you have something like this: loop { if (...) { break; } else { break; } } In this case, the block right after the if statement will be unreachable. This commit makes two