Re: [Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

2018-02-08 Thread Eric Anholt
Marek Olšák writes: > On Wed, Feb 7, 2018 at 1:33 AM, Ilia Mirkin wrote: >> This breaks nouveau (at least on nv50). Same deal as in commit >> 2b938a390c15a06be8cf706083890c822979508f which fixed a similar issue >> where this assumption that buffer doesn't

Re: [Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

2018-02-07 Thread Marek Olšák
On Wed, Feb 7, 2018 at 1:33 AM, Ilia Mirkin wrote: > This breaks nouveau (at least on nv50). Same deal as in commit > 2b938a390c15a06be8cf706083890c822979508f which fixed a similar issue > where this assumption that buffer doesn't need sampler was also > temporarily

Re: [Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

2018-02-06 Thread Ilia Mirkin
This breaks nouveau (at least on nv50). Same deal as in commit 2b938a390c15a06be8cf706083890c822979508f which fixed a similar issue where this assumption that buffer doesn't need sampler was also temporarily introduced. Do I need to go change a ton of stuff in nouveau, or can we stick with the

Re: [Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

2017-06-19 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 15.06.2017 03:08, Marek Olšák wrote: From: Marek Olšák --- This prevents a crash later in the series, and it's generally a good thing to do. src/mesa/state_tracker/st_atom_sampler.c | 11 +--

[Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

2017-06-14 Thread Marek Olšák
From: Marek Olšák --- This prevents a crash later in the series, and it's generally a good thing to do. src/mesa/state_tracker/st_atom_sampler.c | 11 +-- src/mesa/state_tracker/st_texture.c | 5 +++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff