Re: [Mesa-dev] [PATCH 11/13] gallium/util: implement pack functions for Z32F and Z32F_S8X24

2011-07-01 Thread Keith Whitwell
On Fri, 2011-07-01 at 14:42 +0200, Marek Olšák wrote: > On Fri, Jul 1, 2011 at 10:49 AM, Keith Whitwell wrote: > > On Fri, 2011-07-01 at 02:29 +0200, Marek Olšák wrote: > >> The suffix of 64 means it returns uint64_t. > > > > It might be slightly clearer to call these functions util_pack64_{xxx} >

Re: [Mesa-dev] [PATCH 11/13] gallium/util: implement pack functions for Z32F and Z32F_S8X24

2011-07-01 Thread Marek Olšák
On Fri, Jul 1, 2011 at 10:49 AM, Keith Whitwell wrote: > On Fri, 2011-07-01 at 02:29 +0200, Marek Olšák wrote: >> The suffix of 64 means it returns uint64_t. > > It might be slightly clearer to call these functions util_pack64_{xxx} > -- currently it reads as if it is packing 64-bit source data.

Re: [Mesa-dev] [PATCH 11/13] gallium/util: implement pack functions for Z32F and Z32F_S8X24

2011-07-01 Thread Keith Whitwell
On Fri, 2011-07-01 at 02:29 +0200, Marek Olšák wrote: > The suffix of 64 means it returns uint64_t. It might be slightly clearer to call these functions util_pack64_{xxx} -- currently it reads as if it is packing 64-bit source data. Keith > --- > src/gallium/auxiliary/util/u_pack_color.h | 64

[Mesa-dev] [PATCH 11/13] gallium/util: implement pack functions for Z32F and Z32F_S8X24

2011-06-30 Thread Marek Olšák
The suffix of 64 means it returns uint64_t. --- src/gallium/auxiliary/util/u_pack_color.h | 64 + 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/util/u_pack_color.h b/src/gallium/auxiliary/util/u_pack_color.h index 5378f2d..d2df