Re: [Mesa-dev] [PATCH 11/16] glsl: Add ir_binop_pow to get_range

2014-11-19 Thread Ian Romanick
On 11/16/2014 05:51 PM, Thomas Helland wrote: > The spec states that pow is undefined for x < 0. > Just set the range to correspond to a constant 0 > if this is the case. It is technically undefined, but I think all hardware either follows the SM2.0 rules[1] or the SM5 rules[2]. Since a lot of th

Re: [Mesa-dev] [PATCH 11/16] glsl: Add ir_binop_pow to get_range

2014-11-17 Thread Thomas Helland
2014-11-17 18:28 GMT+01:00 Thomas Helland : > 2014-11-17 15:48 GMT+01:00 Bruno Jimenez : >> On Mon, 2014-11-17 at 02:51 +0100, Thomas Helland wrote: >>> The spec states that pow is undefined for x < 0. >>> Just set the range to correspond to a constant 0 >>> if this is the case. >>> --- >>> src/gl

Re: [Mesa-dev] [PATCH 11/16] glsl: Add ir_binop_pow to get_range

2014-11-17 Thread Bruno Jimenez
On Mon, 2014-11-17 at 02:51 +0100, Thomas Helland wrote: > The spec states that pow is undefined for x < 0. > Just set the range to correspond to a constant 0 > if this is the case. > --- > src/glsl/opt_minmax.cpp | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/glsl/opt_

[Mesa-dev] [PATCH 11/16] glsl: Add ir_binop_pow to get_range

2014-11-16 Thread Thomas Helland
The spec states that pow is undefined for x < 0. Just set the range to correspond to a constant 0 if this is the case. --- src/glsl/opt_minmax.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/glsl/opt_minmax.cpp b/src/glsl/opt_minmax.cpp index 9852dd9..ad8c88a 100644 --- a/