[Mesa-dev] [PATCH 12/13] swr/rast: split gen_knobs template into .cpp and .h files

2017-07-31 Thread Tim Rowley
--- src/gallium/drivers/swr/Makefile.am| 3 +- src/gallium/drivers/swr/SConscript | 4 +- .../drivers/swr/rasterizer/codegen/gen_knobs.py| 14 +- .../swr/rasterizer/codegen/templates/gen_knobs.cpp | 112 +--- .../swr/rasterizer/codegen/templates

Re: [Mesa-dev] [PATCH 12/13] swr/rast: split gen_knobs template into .cpp and .h files

2017-07-31 Thread Emil Velikov
Hi Tim, What's the goal behind the split. Please add a couple of words in the commit message. On 31 July 2017 at 20:40, Tim Rowley wrote: > --- > src/gallium/drivers/swr/Makefile.am| 3 +- > src/gallium/drivers/swr/SConscript | 4 +- > .../drivers/swr/rasteri

Re: [Mesa-dev] [PATCH 12/13] swr/rast: split gen_knobs template into .cpp and .h files

2017-08-01 Thread Rowley, Timothy O
On Jul 31, 2017, at 3:18 PM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: Hi Tim, What's the goal behind the split. Please add a couple of words in the commit message. Will do. On 31 July 2017 at 20:40, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: --- src/gallium/drivers/s