Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-29 Thread Chad Versace
On Thu 28 May 2015, Marek Olšák wrote: > A new patch is attached. Please review. LGTM. Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-29 Thread Chad Versace
On Thu 28 May 2015, Eirik Byrkjeflot Anonsen wrote: > Marek Olšák writes: > > > I don't understand. Using size_t should prevent the integer overflow. > > Is there anything else wrong other than no fail path for malloc? I > > also don't understand how calloc can help here. > > > > Marek > > "size

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-28 Thread Marek Olšák
A new patch is attached. Please review. Marek On Wed, May 27, 2015 at 9:07 PM, Chad Versace wrote: > On Fri 15 May 2015, Emil Velikov wrote: >> On 12/05/15 22:54, Marek Olšák wrote: >> > From: Marek Olšák >> > >> > --- >> > src/egl/main/eglapi.c | 38 ++ >> >

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-28 Thread Eirik Byrkjeflot Anonsen
Marek Olšák writes: > I don't understand. Using size_t should prevent the integer overflow. > Is there anything else wrong other than no fail path for malloc? I > also don't understand how calloc can help here. > > Marek "size * sizeof(int_attribs[0])" may overflow and thus wrap to a small numbe

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-28 Thread Marek Olšák
I don't understand. Using size_t should prevent the integer overflow. Is there anything else wrong other than no fail path for malloc? I also don't understand how calloc can help here. Marek On Wed, May 27, 2015 at 9:07 PM, Chad Versace wrote: > On Fri 15 May 2015, Emil Velikov wrote: >> On 12/

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-27 Thread Chad Versace
On Fri 15 May 2015, Emil Velikov wrote: > On 12/05/15 22:54, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/egl/main/eglapi.c | 38 ++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c > > in

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-15 Thread Emil Velikov
On 12/05/15 22:54, Marek Olšák wrote: > From: Marek Olšák > > --- > src/egl/main/eglapi.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c > index 6457798..34a113b 100644 > --- a/src/egl/main/eglapi.c

[Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglapi.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 6457798..34a113b 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -251,6 +251,30 @@ _eglUnl