[Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-07 Thread Samuel Iglesias Gonsálvez
From: Connor Abbott When we replace an expresion we have to compute bitsize information for the replacement. We do this in two passes to validate that bitsize information is consistent and correct: first we propagate bitsize from child nodes to parent, then we do it the other way around, starting

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > When we replace an expresion we have to compute bitsize information for the > replacement. We do this in two passes to validate that bitsize information > is consistent and correct:

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-15 Thread Iago Toral
On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > wrote: > From: Connor Abbott > > When we replace an expresion we have to compute bitsize > information for the > replacement. We d

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-15 Thread Jason Ekstrand
On Tue, Mar 15, 2016 at 12:41 AM, Iago Toral wrote: > On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: > > > > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > > wrote: > > From: Connor Abbott > > > > When we replace an expresion we have to compute bitsiz

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-16 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15/03/16 08:41, Iago Toral wrote: > On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: [...] >> + nir_alu_type type; + union { - uint32_t u; - >> int32_t i; - float f; + uint64_t u; + int64_t i; + >> double d; } data;

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-16 Thread Iago Toral
On Wed, 2016-03-16 at 09:48 +0100, Samuel Iglesias Gonsálvez wrote: > > On 15/03/16 08:41, Iago Toral wrote: > > On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: > [...] > >> + nir_alu_type type; + union { - uint32_t u; - > >> int32_t i; - float f; + uint64_t u; + int

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-19 Thread Jason Ekstrand
On Wed, Mar 16, 2016 at 2:01 AM, Iago Toral wrote: > On Wed, 2016-03-16 at 09:48 +0100, Samuel Iglesias Gonsálvez wrote: > > > > On 15/03/16 08:41, Iago Toral wrote: > > > On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: > > [...] > > >> + nir_alu_type type; + union { - uint32_t u;

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-19 Thread Jason Ekstrand
On Thu, Mar 17, 2016 at 5:15 AM, Iago Toral wrote: > On Wed, 2016-03-16 at 10:54 -0700, Jason Ekstrand wrote: > > > > > > On Wed, Mar 16, 2016 at 2:01 AM, Iago Toral wrote: > > On Wed, 2016-03-16 at 09:48 +0100, Samuel Iglesias Gonsálvez > > wrote: > > > > > > On

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-19 Thread Iago Toral
On Wed, 2016-03-16 at 10:54 -0700, Jason Ekstrand wrote: > > > On Wed, Mar 16, 2016 at 2:01 AM, Iago Toral wrote: > On Wed, 2016-03-16 at 09:48 +0100, Samuel Iglesias Gonsálvez > wrote: > > > > On 15/03/16 08:41, Iago Toral wrote: > > > On Mon, 2016-03-14