Re: [Mesa-dev] [PATCH 147/133] nir: Make intrinsic flags into an enum

2015-01-08 Thread Connor Abbott
On Tue, Jan 6, 2015 at 6:27 PM, Jason Ekstrand wrote: > > > On Mon, Jan 5, 2015 at 11:26 PM, Connor Abbott wrote: >> >> Can you make the fields lowercase to match the algebraic properties >> enum? Or did you make that uppercase? Lowercase feels better to me >> since it's an enum, but I don't real

Re: [Mesa-dev] [PATCH 147/133] nir: Make intrinsic flags into an enum

2015-01-06 Thread Jason Ekstrand
On Mon, Jan 5, 2015 at 11:26 PM, Connor Abbott wrote: > Can you make the fields lowercase to match the algebraic properties > enum? Or did you make that uppercase? Lowercase feels better to me > since it's an enum, but I don't really care too much. > I prefer upper-case for bitfields which is re

Re: [Mesa-dev] [PATCH 147/133] nir: Make intrinsic flags into an enum

2015-01-05 Thread Connor Abbott
Can you make the fields lowercase to match the algebraic properties enum? Or did you make that uppercase? Lowercase feels better to me since it's an enum, but I don't really care too much. On Fri, Dec 19, 2014 at 8:02 PM, Jason Ekstrand wrote: > This should be much better for debugging as GDB wil

[Mesa-dev] [PATCH 147/133] nir: Make intrinsic flags into an enum

2014-12-19 Thread Jason Ekstrand
This should be much better for debugging as GDB will pick up on the fact that it's an enum and actually tell you what you're looking at instead of giving you some arbitrary hex value you have to go look up. --- src/glsl/nir/nir.h | 28 ++-- 1 file changed, 14 insertions(+),