Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Chris Forbes
Nevermind, pre-coffee. On re-reading the GLSL ES 3.1 spec, the offset is required to be constant wherever texture offsets are used. On Fri, May 1, 2015 at 10:03 AM, Ilia Mirkin wrote: > On Thu, Apr 30, 2015 at 5:56 PM, Chris Forbes wrote: >>> /* Only ARB_texture_gather but not GLSL 4.0 or ARB_g

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Ilia Mirkin
On Thu, Apr 30, 2015 at 5:56 PM, Chris Forbes wrote: >> /* Only ARB_texture_gather but not GLSL 4.0 or ARB_gpu_shader5. >> * used for relaxation of const offset requirements. >> */ >> static bool >> -texture_gather_only(const _mesa_glsl_parse_state *state) >> +texture_gather_only_or_es31(con

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Chris Forbes
> /* Only ARB_texture_gather but not GLSL 4.0 or ARB_gpu_shader5. > * used for relaxation of const offset requirements. > */ > static bool > -texture_gather_only(const _mesa_glsl_parse_state *state) > +texture_gather_only_or_es31(const _mesa_glsl_parse_state *state) > { > return !state->

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Tapani Pälli
Patches 1 .. 15 (with the 2 little changes proposed) Reviewed-by: Tapani Pälli I went through built-in functions in the 3.1 spec and checked that the packing functions, integer mix, textureGather variants, bitField operations, ldexp and frexp are listed there. I've also cross-checked agains

[Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/builtin_functions.cpp | 90 -- 1 file changed, 61 insertions(+), 29 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 72fb5e0..b202b39 100644 --- a/