Re: [Mesa-dev] [PATCH 16/24] mesa: Implement glSpecializeShaderARB

2017-11-28 Thread Eduardo Lima
On 11/27/2017 11:06 AM, Alejandro Piñeiro wrote: On 27/11/17 03:22, Timothy Arceri wrote: I suspect this patch doesn't compile. I think pEntryPoint is meant to be passed as an argument to this function. pEntryPoint is passed as an argument. What makes you think it is not? It is the second

Re: [Mesa-dev] [PATCH 16/24] mesa: Implement glSpecializeShaderARB

2017-11-27 Thread Alejandro Piñeiro
On 27/11/17 03:22, Timothy Arceri wrote: > I suspect this patch doesn't compile. I think pEntryPoint is meant to > be passed as an argument to this function. It is the second parameter of the method. But it is true that it doesn't appear on this patch. Seems that the diff skipped some lines

Re: [Mesa-dev] [PATCH 16/24] mesa: Implement glSpecializeShaderARB

2017-11-26 Thread Timothy Arceri
I suspect this patch doesn't compile. I think pEntryPoint is meant to be passed as an argument to this function. On 16/11/17 00:22, Eduardo Lima Mitev wrote: From: Nicolai Hähnle v2: use gl_spirv_validation instead of spirv_to_nir. This method just validates the

[Mesa-dev] [PATCH 16/24] mesa: Implement glSpecializeShaderARB

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) v3: Use gl_shader_spirv_data struct to store the SPIR-V data. (Eduardo