[Mesa-dev] [PATCH 17/28] intel/nir: call nir_opt_constant_folding before nir_opt_algebraic is executed

2018-12-05 Thread Samuel Iglesias Gonsálvez
This would do constant folding and also flush to zero denorms operands before the nir_opt_algebraic is executed. Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/

Re: [Mesa-dev] [PATCH 17/28] intel/nir: call nir_opt_constant_folding before nir_opt_algebraic is executed

2018-12-05 Thread Connor Abbott
Why is this needed? In general, we shouldn't be relying on optimization ordering for correctness. It probably just means one of the optimizations is wrong, and you're working around that. On Wed, Dec 5, 2018 at 4:56 PM Samuel Iglesias Gonsálvez wrote: > > This would do constant folding and also fl

Re: [Mesa-dev] [PATCH 17/28] intel/nir: call nir_opt_constant_folding before nir_opt_algebraic is executed

2018-12-10 Thread Samuel Iglesias Gonsálvez
On 05/12/2018 19:22, Connor Abbott wrote: > Why is this needed? In general, we shouldn't be relying on > optimization ordering for correctness. It probably just means one of > the optimizations is wrong, and you're working around that. There is an issue when the shader tries to generate a NaN usin

Re: [Mesa-dev] [PATCH 17/28] intel/nir: call nir_opt_constant_folding before nir_opt_algebraic is executed

2018-12-10 Thread Connor Abbott
On Mon, Dec 10, 2018 at 2:20 PM Samuel Iglesias Gonsálvez wrote: > > On 05/12/2018 19:22, Connor Abbott wrote: > > Why is this needed? In general, we shouldn't be relying on > > optimization ordering for correctness. It probably just means one of > > the optimizations is wrong, and you're working