Re: [Mesa-dev] [PATCH 18/18] i965: Convert WM_STATE to genxml on gen4-5.

2017-07-17 Thread Kenneth Graunke
On Friday, June 16, 2017 4:31:31 PM PDT Rafael Antognolli wrote: > The code doesn't get exactly a lot simpler but at least it is in a single > place, and we delete more than we add. > > Signed-off-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/Makefile.sources| 1 - > src/mesa/dri

Re: [Mesa-dev] [PATCH 18/18] i965: Convert WM_STATE to genxml on gen4-5.

2017-06-19 Thread Kristian Høgsberg
On Mon, Jun 19, 2017 at 11:17 AM, Rafael Antognolli wrote: > On Mon, Jun 19, 2017 at 09:46:30AM -0700, Kristian Høgsberg wrote: >> On Fri, Jun 16, 2017 at 4:31 PM, Rafael Antognolli >> wrote: >> > The code doesn't get exactly a lot simpler but at least it is in a single >> > place, and we delete

Re: [Mesa-dev] [PATCH 18/18] i965: Convert WM_STATE to genxml on gen4-5.

2017-06-19 Thread Rafael Antognolli
On Mon, Jun 19, 2017 at 09:46:30AM -0700, Kristian Høgsberg wrote: > On Fri, Jun 16, 2017 at 4:31 PM, Rafael Antognolli > wrote: > > The code doesn't get exactly a lot simpler but at least it is in a single > > place, and we delete more than we add. > > Another good point is that you get rid of s

Re: [Mesa-dev] [PATCH 18/18] i965: Convert WM_STATE to genxml on gen4-5.

2017-06-19 Thread Kristian Høgsberg
On Fri, Jun 16, 2017 at 4:31 PM, Rafael Antognolli wrote: > The code doesn't get exactly a lot simpler but at least it is in a single > place, and we delete more than we add. Another good point is that you get rid of struct brw_wm_unit_state which was a third mechanism for encoding GEN state. We

[Mesa-dev] [PATCH 18/18] i965: Convert WM_STATE to genxml on gen4-5.

2017-06-16 Thread Rafael Antognolli
The code doesn't get exactly a lot simpler but at least it is in a single place, and we delete more than we add. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_state.h | 1 - src/mesa/drivers/dri/i965/brw_struct