Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-06 Thread Marek Olšák
On Fri, Jan 6, 2012 at 4:28 AM, Eric Anholt wrote: > So when someone changes from a program using samplerunits bound one way > to a program using samplerunits bound another way, are you expecting > glUseProgram to flag _NEW_TEXTURE?  Because it doesn't. Yes it doesn't, but st/mesa always looks if

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-05 Thread Eric Anholt
On Thu, 5 Jan 2012 01:31:22 +0100, Marek Olšák wrote: > On Thu, Jan 5, 2012 at 12:45 AM, Eric Anholt wrote: > > On Wed, 04 Jan 2012 03:28:12 -0800, Kenneth Graunke > > wrote: > >> On 01/03/2012 09:43 PM, Marek Olšák wrote: > >> > This ProgramStringNotify call causes excessive shader recompilati

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Ian Romanick
On 01/03/2012 09:43 PM, Marek Olšák wrote: On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanick wrote: diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index db2f200..50a724b 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uniform_query.cpp @@ -22,15 +22,

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Marek Olšák
On Thu, Jan 5, 2012 at 12:45 AM, Eric Anholt wrote: > On Wed, 04 Jan 2012 03:28:12 -0800, Kenneth Graunke > wrote: >> On 01/03/2012 09:43 PM, Marek Olšák wrote: >> > This ProgramStringNotify call causes excessive shader recompilations >> > in the game Cogs (from some Humble Bundle). Approximatel

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Eric Anholt
On Wed, 04 Jan 2012 03:28:12 -0800, Kenneth Graunke wrote: > On 01/03/2012 09:43 PM, Marek Olšák wrote: > > This ProgramStringNotify call causes excessive shader recompilations > > in the game Cogs (from some Humble Bundle). Approximately 25% of > > in-game CPU time is spent on translating shader

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Marek Olšák
On Wed, Jan 4, 2012 at 12:28 PM, Kenneth Graunke wrote: > On 01/03/2012 09:43 PM, Marek Olšák wrote: >> On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanick wrote: >>> diff --git a/src/mesa/main/uniform_query.cpp >>> b/src/mesa/main/uniform_query.cpp >>> index db2f200..50a724b 100644 >>> --- a/src/mesa

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 09:43 PM, Marek Olšák wrote: > On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanick wrote: >> diff --git a/src/mesa/main/uniform_query.cpp >> b/src/mesa/main/uniform_query.cpp >> index db2f200..50a724b 100644 >> --- a/src/mesa/main/uniform_query.cpp >> +++ b/src/mesa/main/uniform_query.cpp

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-03 Thread Marek Olšák
On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanick wrote: > diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp > index db2f200..50a724b 100644 > --- a/src/mesa/main/uniform_query.cpp > +++ b/src/mesa/main/uniform_query.cpp > @@ -22,15 +22,16 @@ >  * AN ACTION OF CONTRACT, TO

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2011-11-08 Thread Vadim Girlin
Hi, Not sure if it's directly related to this patch, but I got memory corruption with 32-bit Lightsmark, bisected to corresponding commit. I'm attaching related part of the valgrind log. Vadim ==2800== Invalid write of size 4 ==2800==at 0x4D7C510: memcpy (mc_replace_strmem.c:643) ==2800==

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2011-10-31 Thread Ian Romanick
On 10/28/2011 02:45 PM, Eric Anholt wrote: On Fri, 28 Oct 2011 10:42:45 -0700, "Ian Romanick" wrote: From: Ian Romanick Switch all of the code in ir_to_mesa, st_glsl_to_tgsi, glUniform*, glGetUniform, glGetUniformLocation, and glGetActiveUniforms to use the gl_uniform_storage structures in the

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2011-10-28 Thread Eric Anholt
On Fri, 28 Oct 2011 10:42:45 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > Switch all of the code in ir_to_mesa, st_glsl_to_tgsi, glUniform*, > glGetUniform, glGetUniformLocation, and glGetActiveUniforms to use the > gl_uniform_storage structures in the gl_shader_program. > > A couple o

[Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2011-10-28 Thread Ian Romanick
From: Ian Romanick Switch all of the code in ir_to_mesa, st_glsl_to_tgsi, glUniform*, glGetUniform, glGetUniformLocation, and glGetActiveUniforms to use the gl_uniform_storage structures in the gl_shader_program. A couple of notes: * Like most rewrite-the-world patches, this should be reviewed