Re: [Mesa-dev] [PATCH 2/2] anv: Throw INCOMPATIBLE_DRIVER for non-fatal initialization errors

2016-08-23 Thread Jason Ekstrand
On Tue, Aug 23, 2016 at 2:17 AM, Emil Velikov wrote: > On 23 August 2016 at 02:11, Jason Ekstrand wrote: > > The only reason we should throw INITIALIZATION_FAILED is if we have found > > useable intel hardware but have failed to bring it up for some reason. > > Otherwise, we should just throw IN

Re: [Mesa-dev] [PATCH 2/2] anv: Throw INCOMPATIBLE_DRIVER for non-fatal initialization errors

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 02:11, Jason Ekstrand wrote: > The only reason we should throw INITIALIZATION_FAILED is if we have found > useable intel hardware but have failed to bring it up for some reason. > Otherwise, we should just throw INCOMPATIBLE_DRIVER which will turn into > successfully advertisi

Re: [Mesa-dev] [PATCH 2/2] anv: Throw INCOMPATIBLE_DRIVER for non-fatal initialization errors

2016-08-22 Thread Bas Nieuwenhuizen
This patch is Reviewed-by: Bas Nieuwenhuizen Tested-by: Bas Nieuwenhuizen Thanks. On Tue, Aug 23, 2016 at 3:11 AM, Jason Ekstrand wrote: > The only reason we should throw INITIALIZATION_FAILED is if we have found > useable intel hardware but have failed to bring it up for some reason. > Other

[Mesa-dev] [PATCH 2/2] anv: Throw INCOMPATIBLE_DRIVER for non-fatal initialization errors

2016-08-22 Thread Jason Ekstrand
The only reason we should throw INITIALIZATION_FAILED is if we have found useable intel hardware but have failed to bring it up for some reason. Otherwise, we should just throw INCOMPATIBLE_DRIVER which will turn into successfully advertising 0 physical devices --- src/intel/vulkan/anv_device.c |