Re: [Mesa-dev] [PATCH 2/2] i965/fs: Don't double-accept operands of logical and/or/xor operations.

2013-09-23 Thread Kenneth Graunke
On 09/23/2013 02:52 PM, Matt Turner wrote: > On Mon, Sep 23, 2013 at 2:12 PM, Kenneth Graunke > wrote: >> emit_bool_to_cond_code() takes separate paths for ir_expressions and. > > Sentence ends unexpectedly? Oops. I meant to delete that. >> If the argument to emit_bool_to_cond_code() is an ir

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Don't double-accept operands of logical and/or/xor operations.

2013-09-23 Thread Matt Turner
On Mon, Sep 23, 2013 at 2:12 PM, Kenneth Graunke wrote: > emit_bool_to_cond_code() takes separate paths for ir_expressions and. Sentence ends unexpectedly? > If the argument to emit_bool_to_cond_code() is an ir_expression, we > loop over the operands, calling accept() on each of them, which > ge

[Mesa-dev] [PATCH 2/2] i965/fs: Don't double-accept operands of logical and/or/xor operations.

2013-09-23 Thread Kenneth Graunke
emit_bool_to_cond_code() takes separate paths for ir_expressions and. If the argument to emit_bool_to_cond_code() is an ir_expression, we loop over the operands, calling accept() on each of them, which generates assembly code to compute that subexpression. We then emit one or two final instructio