[Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Plamena Manolova
This patch adds the implentation of ARB_compute_variable_group_size for i965. We do this by storing the group size in a buffer surface, similarly to the work group number. Signed-off-by: Plamena Manolova --- docs/features.txt| 2 +- docs/relnotes/18.2.0.html

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Ilia Mirkin
On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova wrote: > This patch adds the implentation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Jordan Justen
On 2018-06-01 15:21:34, Plamena Manolova wrote: > This patch adds the implentation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Matt Turner
On Fri, Jun 1, 2018 at 3:21 PM, Plamena Manolova wrote: > This patch adds the implentation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
Ah, that's true, I'll switch them around. Thank you for reviewing Matt! On Sat, 2 Jun 2018 at 04:58, Matt Turner wrote: > On Fri, Jun 1, 2018 at 3:21 PM, Plamena Manolova > wrote: > > This patch adds the implentation of ARB_compute_variable_group_size > > for i965. We do this by storing the gro

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
Thank you for reviewing this Jordan! On Fri, 1 Jun 2018 at 23:45, Jordan Justen wrote: > On 2018-06-01 15:21:34, Plamena Manolova wrote: > > This patch adds the implentation of ARB_compute_variable_group_size > > for i965. We do this by storing the group size in a buffer surface, > > similarly t

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
Thank you for the review Ilia! On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote: > On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova > wrote: > > This patch adds the implentation of ARB_compute_variable_group_size > > for i965. We do this by storing the group size in a buffer surface, > > similarl

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Ilia Mirkin
On Mon, Jun 4, 2018 at 4:30 PM, Plamena Manolova wrote: > Thank you for the review Ilia! > > On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote: >> >> On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova >> wrote: >> > + /* >> > + * If the local work group size is variable we have to use a >>

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
On Mon, 4 Jun 2018 at 21:36, Ilia Mirkin wrote: > On Mon, Jun 4, 2018 at 4:30 PM, Plamena Manolova > wrote: > > Thank you for the review Ilia! > > > > On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote: > >> > >> On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova > >> wrote: > >> > + /* > >> >