Re: [Mesa-dev] [PATCH 2/2] i965: check each field separately in backend_end::equals()

2016-05-12 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 13/05/16 05:38, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> Extra bits required to make room for the df field of the union >> don't get initialized in all codepaths, so backend_reg >> comparisons done using memcmp() can bas

Re: [Mesa-dev] [PATCH 2/2] i965: check each field separately in backend_end::equals()

2016-05-12 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > Extra bits required to make room for the df field of the union don't get > initialized in all codepaths, so backend_reg comparisons done using > memcmp() can basically return random results. Check field by field to > avoid this. > > Signed-off-by: Samuel Iglesi

[Mesa-dev] [PATCH 2/2] i965: check each field separately in backend_end::equals()

2016-05-12 Thread Samuel Iglesias Gonsálvez
Extra bits required to make room for the df field of the union don't get initialized in all codepaths, so backend_reg comparisons done using memcmp() can basically return random results. Check field by field to avoid this. Signed-off-by: Samuel Iglesias Gonsálvez Reported-by: Francisco Jerez ---