Re: [Mesa-dev] [PATCH 2/2] i965: don't drop const initializers in vector splitting

2016-06-25 Thread Rob Clark
On Sat, Jun 25, 2016 at 10:29 AM, Jason Ekstrand wrote: > > On Jun 25, 2016 5:39 AM, "Rob Clark" wrote: >> >> From: Rob Clark >> >> Not entirely sure how we didn't hit this before, but dropping the const >> initializer on the floor is obviously not correct. >> >> Signed-off-by: Rob Clark >> ---

Re: [Mesa-dev] [PATCH 2/2] i965: don't drop const initializers in vector splitting

2016-06-25 Thread Jason Ekstrand
On Jun 25, 2016 5:39 AM, "Rob Clark" wrote: > > From: Rob Clark > > Not entirely sure how we didn't hit this before, but dropping the const > initializer on the floor is obviously not correct. > > Signed-off-by: Rob Clark > --- > No idea why i965 even still uses this pass, vs nir scalarizing pas

[Mesa-dev] [PATCH 2/2] i965: don't drop const initializers in vector splitting

2016-06-25 Thread Rob Clark
From: Rob Clark Not entirely sure how we didn't hit this before, but dropping the const initializer on the floor is obviously not correct. Signed-off-by: Rob Clark --- No idea why i965 even still uses this pass, vs nir scalarizing pass. So might want to drop this. But I figured fixing it first