Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Marek Olšák
r600g and radeonsi need to have the same texture target in both the sampler view and the shader. You cannot remove the sampler view target in favor of the shader one. Marek On Wed, Aug 20, 2014 at 10:58 PM, Roland Scheidegger wrote: > Am 20.08.2014 22:27, schrieb Ilia Mirkin: >> On Wed, Aug 20,

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Marek Olšák
No, r300 cannot use cubemaps as 2D textures (in theory it could, but mipmapping would be broken). That means r300g cannot support ARB_texture_view. Marek On Wed, Aug 20, 2014 at 6:14 PM, Roland Scheidegger wrote: > Am 20.08.2014 17:55, schrieb Ilia Mirkin: >> On Wed, Aug 20, 2014 at 11:47 AM, Jo

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 22:27, schrieb Ilia Mirkin: > On Wed, Aug 20, 2014 at 4:12 PM, Roland Scheidegger > wrote: >> Am 20.08.2014 18:48, schrieb Roland Scheidegger: >>> Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: > On 20/08/14 17:14, Roland Sc

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
On Wed, Aug 20, 2014 at 4:12 PM, Roland Scheidegger wrote: > Am 20.08.2014 18:48, schrieb Roland Scheidegger: >> Am 20.08.2014 18:33, schrieb Ilia Mirkin: >>> On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: On 20/08/14 17:14, Roland Scheidegger wrote: > > Am 20.08.2014 17:55, s

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:48, schrieb Roland Scheidegger: > Am 20.08.2014 18:33, schrieb Ilia Mirkin: >> On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: >>> On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: > > On Wed, Aug 20, 2014 at 11:47 AM, J

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:33, schrieb Ilia Mirkin: > On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: >> On 20/08/14 17:14, Roland Scheidegger wrote: >>> >>> Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca wrote: > > On 20/08/14 16:31, I

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Jose Fonseca
On 20/08/14 17:33, Ilia Mirkin wrote: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca wrote: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not t

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:12, schrieb Jose Fonseca: > On 20/08/14 17:02, Roland Scheidegger wrote: >> Am 20.08.2014 17:47, schrieb Jose Fonseca: >>> On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_reso

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: > On 20/08/14 17:14, Roland Scheidegger wrote: >> >> Am 20.08.2014 17:55, schrieb Ilia Mirkin: >>> >>> On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca >>> wrote: On 20/08/14 16:31, Ilia Mirkin wrote: > > > Hm, it's not tes

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Jose Fonseca
On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca wrote: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resour

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 17:55, schrieb Ilia Mirkin: > On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca wrote: >> On 20/08/14 16:31, Ilia Mirkin wrote: >>> >>> Hm, it's not tested. And you're right, that would (most likely) mess >>> up, since it would only have the pipe_resource's target. Any >>> suggestions o

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Jose Fonseca
On 20/08/14 17:02, Roland Scheidegger wrote: Am 20.08.2014 17:47, schrieb Jose Fonseca: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any suggestions on how to fix it? Should th

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 17:47, schrieb Jose Fonseca: > On 20/08/14 16:31, Ilia Mirkin wrote: >> Hm, it's not tested. And you're right, that would (most likely) mess >> up, since it would only have the pipe_resource's target. Any >> suggestions on how to fix it? Should the target be added to >> pipe_sampler_v

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca wrote: > On 20/08/14 16:31, Ilia Mirkin wrote: >> >> Hm, it's not tested. And you're right, that would (most likely) mess >> up, since it would only have the pipe_resource's target. Any >> suggestions on how to fix it? Should the target be added to >>

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Jose Fonseca
On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any suggestions on how to fix it? Should the target be added to pipe_sampler_view? On Wed, Aug 20, 2014 at 11:25 AM, Roland Scheideg

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any suggestions on how to fix it? Should the target be added to pipe_sampler_view? On Wed, Aug 20, 2014 at 11:25 AM, Roland Scheidegger wrote: > Didn't look at it that clo

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Didn't look at it that closely, but I'm pretty surprised this really works. One things ARB_texture_view can do is cast cube maps (and cube map arrays) to 2d arrays and vice versa (also 1d/2d to the respective array type), and we cannot express that in sampler views (yet) (we can't express it in sur

[Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- No piglit regressions on nvc0 except for gl-3.0-render-integer, which appears to now fail even without this commit, despite the fact that I'm fairly sure it used to work fine. Same failure with llvmpipe... It's most likely that I've missed some details. It's unclea