Re: [Mesa-dev] [PATCH 2/2] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-11-24 Thread Karol Herbst
On Sun, Nov 25, 2018 at 2:11 AM Ilia Mirkin wrote: > > Using this approach, num_samplers will never go down. Also, this > applies to more than just samplers -- textures, everything else. but is this a problem? I was checking on where num_samplers was used and I don't see that it make much of a di

Re: [Mesa-dev] [PATCH 2/2] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-11-24 Thread Ilia Mirkin
Using this approach, num_samplers will never go down. Also, this applies to more than just samplers -- textures, everything else. On Sat, Nov 24, 2018 at 6:04 PM Karol Herbst wrote: > > The new approach is that samplers don't get unbound even if they won't be used > in a draw and we should just le

[Mesa-dev] [PATCH 2/2] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-11-24 Thread Karol Herbst
The new approach is that samplers don't get unbound even if they won't be used in a draw and we should just leave them be as well. Fixes a regression in multiple windows games using gallium nine and nouveau. Fixes: 4d6fab245eec3880e2a59424a579851f44857ce8 "cso: don't track the number of sa