Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 08:34 -0700, Tom Stellard wrote: > On Thu, Jun 19, 2014 at 11:22:28AM -0400, Jan Vesely wrote: > > On Thu, 2014-06-19 at 17:12 +0200, Bruno Jimenez wrote: > > > Hi, > > > > > > To which failure are you refering? Could you please send me a > > > test/program that I can try to

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Tom Stellard
On Thu, Jun 19, 2014 at 11:22:28AM -0400, Jan Vesely wrote: > On Thu, 2014-06-19 at 17:12 +0200, Bruno Jimenez wrote: > > Hi, > > > > To which failure are you refering? Could you please send me a > > test/program that I can try to track this down? > > well, the compute_memory_finalize_pending() f

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 17:12 +0200, Bruno Jimenez wrote: > Hi, > > To which failure are you refering? Could you please send me a > test/program that I can try to track this down? well, the compute_memory_finalize_pending() function can possibly return -1 so it's prudent to check for it. as for th

[Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
Signed-off-by: Jan Vesely CC: Bruno Jimenez --- The failure now hits assertion compute_memory_pool.c:408, instead of u_inlines.h:275:pipe_buffer_map_range: Assertion `offset < buffer->width0' src/gallium/drivers/r600/evergreen_compute.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletio

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Bruno Jimenez
Hi, To which failure are you refering? Could you please send me a test/program that I can try to track this down? Thanks! Bruno On Thu, 2014-06-19 at 10:21 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely > CC: Bruno Jimenez > --- > > The failure now hits assertion compute_memory_pool.c:4