Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-05 Thread Tobias Droste
Hi Emil, the approach Dave used is ok and makes this obsolete. I talked about this to him in IRC. I actually _don't_ want a gallium like approach and didn't like this patch too much. This was just he least amount of changes without touching anything else and still make it work. Having said th

Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-05 Thread Emil Velikov
On 2 October 2016 at 20:45, Tobias Droste wrote: > This reuse the same logic gallium uses to determine if LLVM is needed or > not: > --enable-vulkan-llvm is set to yes if at least one vulkan driver is > active and the host is i3*6 or x86_64. > To build vulkan drivers without LLVM (e.g. intel) one

Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-03 Thread Tobias Droste
I was looking at a per driver check for vulkan, but then this can't reuse the existing functions to check llvm version. The LLVM version checks are also the reason this is done is such a weird way for gallium. It doesn't make sense there too and should be per driver too. This patch was just the

Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-03 Thread Dave Airlie
On 3 October 2016 at 05:45, Tobias Droste wrote: > This reuse the same logic gallium uses to determine if LLVM is needed or > not: > --enable-vulkan-llvm is set to yes if at least one vulkan driver is > active and the host is i3*6 or x86_64. > To build vulkan drivers without LLVM (e.g. intel) one

[Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-02 Thread Tobias Droste
This reuse the same logic gallium uses to determine if LLVM is needed or not: --enable-vulkan-llvm is set to yes if at least one vulkan driver is active and the host is i3*6 or x86_64. To build vulkan drivers without LLVM (e.g. intel) one has to add --disable-vulkan-llvm. In order to make this all