Re: [Mesa-dev] [PATCH 2/2] radv: only flush CB meta in pipeline image barriers when needed

2018-07-05 Thread Bas Nieuwenhuizen
On Thu, Jul 5, 2018 at 1:51 PM, Samuel Pitoiset wrote: > > > On 07/05/2018 01:36 PM, Bas Nieuwenhuizen wrote: >> >> On Thu, Jul 5, 2018 at 12:54 PM, Samuel Pitoiset >> wrote: >>> >>> If the given image doesn't enable CMASK, FMASK or DCC that's >>> useless to flush CB metadata. > > > According to

Re: [Mesa-dev] [PATCH 2/2] radv: only flush CB meta in pipeline image barriers when needed

2018-07-05 Thread Samuel Pitoiset
On 07/05/2018 01:36 PM, Bas Nieuwenhuizen wrote: On Thu, Jul 5, 2018 at 12:54 PM, Samuel Pitoiset wrote: If the given image doesn't enable CMASK, FMASK or DCC that's useless to flush CB metadata. According to RadeonSI and AMDVLK, it seems like DCC is included in the CB metadata, so we prob

Re: [Mesa-dev] [PATCH 2/2] radv: only flush CB meta in pipeline image barriers when needed

2018-07-05 Thread Bas Nieuwenhuizen
On Thu, Jul 5, 2018 at 12:54 PM, Samuel Pitoiset wrote: > If the given image doesn't enable CMASK, FMASK or DCC that's > useless to flush CB metadata. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 6 -- > src/amd/vulkan/radv_private.h| 11 +++ > 2

[Mesa-dev] [PATCH 2/2] radv: only flush CB meta in pipeline image barriers when needed

2018-07-05 Thread Samuel Pitoiset
If the given image doesn't enable CMASK, FMASK or DCC that's useless to flush CB metadata. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 6 -- src/amd/vulkan/radv_private.h| 11 +++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/amd/v