Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-30 Thread Erik Faye-Lund
On Tue, Sep 29, 2015 at 7:50 PM, Brian Paul wrote: > > I was actually thinking of expanding this change to cover _all_ color formats > but wanted to take a small step first. What do you think? > I have some patches in this area sitting around here:

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-30 Thread Marek Olšák
On Tue, Sep 29, 2015 at 7:50 PM, Brian Paul wrote: > I was actually thinking of expanding this change to cover _all_ color > formats but wanted to take a small step first. What do you think? Everything that is R, RG, RGB, RGBA should be renderable. Also, SNORM formats are not

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-30 Thread Roland Scheidegger
Am 01.10.2015 um 02:08 schrieb Erik Faye-Lund: > On Tue, Sep 29, 2015 at 7:50 PM, Brian Paul wrote: >> >> I was actually thinking of expanding this change to cover _all_ color >> formats but wanted to take a small step first. What do you think? >> > > I have some patches in

[Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-29 Thread Brian Paul
For 8-bit RGB(A) texture formats we set the PIPE_BIND_RENDER_TARGET flag to try to get a hardware format which also supports rendering (for FBO textures). Do the same thing for floating point formats. This allows the Redway Flat demo to run. --- src/mesa/state_tracker/st_format.c | 6 +- 1

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-29 Thread Marek Olšák
Cc: 10.6 11.0 Reviewed-by: Marek Olšák Marek On Tue, Sep 29, 2015 at 5:39 PM, Brian Paul wrote: > For 8-bit RGB(A) texture formats we set the PIPE_BIND_RENDER_TARGET flag > to try to get a hardware format which also

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-29 Thread Roland Scheidegger
Probably makes sense. Albeit I'm not sure about the L/A/LA/I stuff, probably apps are aware that trying to render to that may fail (and hence potentially choosing some rgb format instead of a single-channel format is really not desirable for those). Roland Am 29.09.2015 um 19:50 schrieb Brian

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-29 Thread Roland Scheidegger
If that was due to some rgb vs. rgbx thing (that is, could texture from rgb but only render to rgbx) I wonder if the same logic shouldn't also apply to the integer formats. But either way (I guess the app should check fbo completeness in any case so strictly speaking for correctness this isn't

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

2015-09-29 Thread Brian Paul
I was actually thinking of expanding this change to cover _all_ color formats but wanted to take a small step first. What do you think? -Brian On 09/29/2015 11:46 AM, Roland Scheidegger wrote: If that was due to some rgb vs. rgbx thing (that is, could texture from rgb but only render to