Re: [Mesa-dev] [PATCH 2/2 (resend)] virgl: Pass resource size and transfer offsets

2018-09-16 Thread Tomeu Vizoso
On 09/14/2018 04:42 PM, Gert Wollny wrote: Am Freitag, den 14.09.2018, 15:26 +0300 schrieb andrey simiklit: [...] + if (vcmd == VCMD_TRANSFER_PUT2) + vtest_hdr[VTEST_CMD_LEN] += data_size + 3 / 4; Looks like a copy/paste mistake) I suppose that it is should be like: ... = (data_size + 3

Re: [Mesa-dev] [PATCH 2/2 (resend)] virgl: Pass resource size and transfer offsets

2018-09-14 Thread Gert Wollny
Am Freitag, den 14.09.2018, 15:26 +0300 schrieb andrey simiklit: [...] > > + if (vcmd == VCMD_TRANSFER_PUT2) > > + vtest_hdr[VTEST_CMD_LEN] += data_size + 3 / 4; > > Looks like a copy/paste mistake) > I suppose that it is should be like: > ... = (data_size + 3) / 4; > or may be just: > ...

Re: [Mesa-dev] [PATCH 2/2 (resend)] virgl: Pass resource size and transfer offsets

2018-09-14 Thread andrey simiklit
Hello, Please find my comment below: Regards, Andrii. On Fri, Sep 14, 2018 at 12:23 PM Gert Wollny wrote: > From: Tomeu Vizoso > > Pass the size of a resource when creating it so a backing can be kept in > the other side. > > Also pass the required offset to transfer commands. > > This moves v

[Mesa-dev] [PATCH 2/2 (resend)] virgl: Pass resource size and transfer offsets

2018-09-14 Thread Gert Wollny
From: Tomeu Vizoso Pass the size of a resource when creating it so a backing can be kept in the other side. Also pass the required offset to transfer commands. This moves vtest closer to how virtio-gpu works, making it more useful for testing. v2: - Use new messages for creation and transfers,