Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-18 Thread Jason Ekstrand
On Thu, Oct 18, 2018 at 3:24 PM Jason Ekstrand wrote: > On Thu, Oct 18, 2018 at 3:17 PM Jan Vesely wrote: > >> Hi, >> >> I think this patch breaks the build: >> https://travis-ci.org/jvesely/mesa/jobs/443356781 >> > > Interesting. It appears that it breaks when you have one of the WSI >

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-18 Thread Jason Ekstrand
On Thu, Oct 18, 2018 at 3:17 PM Jan Vesely wrote: > Hi, > > I think this patch breaks the build: > https://travis-ci.org/jvesely/mesa/jobs/443356781 > Interesting. It appears that it breaks when you have one of the WSI extensions disabled. I'll take a look. --Jason > Jan > > On Tue,

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-18 Thread Jan Vesely
Hi, I think this patch breaks the build: https://travis-ci.org/jvesely/mesa/jobs/443356781 Jan On Tue, 2018-10-16 at 08:18 -0500, Jason Ekstrand wrote: > FYI, patch 1 is required for this patch to build. It also means this patch > found a nice little bug. I'll respond to patch 1 in more

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-16 Thread Jason Ekstrand
FYI, patch 1 is required for this patch to build. It also means this patch found a nice little bug. I'll respond to patch 1 in more detail after the SI call tomorrow. --Jason On October 16, 2018 06:49:35 Lionel Landwerlin wrote: Reviewed-by: Lionel Landwerlin On 15/10/2018 04:47,

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-16 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 15/10/2018 04:47, Jason Ekstrand wrote: We don't need weak references to instance entrypoints because we never have more than one of each so we don't need the NULL fall-back. This also helps us avoid forgetting things because we now get link errors for

[Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-14 Thread Jason Ekstrand
We don't need weak references to instance entrypoints because we never have more than one of each so we don't need the NULL fall-back. This also helps us avoid forgetting things because we now get link errors for missing instance entrypoints. --- src/intel/vulkan/anv_entrypoints_gen.py | 13