Re: [Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

2017-05-04 Thread Adam Jackson
On Thu, 2017-05-04 at 13:00 +0100, Emil Velikov wrote: > On 3 May 2017 at 16:57, Adam Jackson wrote: > > If the gbm_create_device() call here actually did fail, any > > subsequent > > eglTerminate on the display would segfault. > > > > We do have a couple of checks after we set own_device, altho

Re: [Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

2017-05-04 Thread Emil Velikov
On 3 May 2017 at 16:57, Adam Jackson wrote: > If the gbm_create_device() call here actually did fail, any subsequent > eglTerminate on the display would segfault. > We do have a couple of checks after we set own_device, although both are close to impossible to trigger. Cc: Reviewed-by: Emil Veli

Re: [Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

2017-05-03 Thread Eric Anholt
Adam Jackson writes: > If the gbm_create_device() call here actually did fail, any subsequent > eglTerminate on the display would segfault. #1 and 2 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list me

[Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

2017-05-03 Thread Adam Jackson
If the gbm_create_device() call here actually did fail, any subsequent eglTerminate on the display would segfault. Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/platform_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/eg