Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-02 Thread Marek Olšák
One possibility would be to discard each hunk in each patch until you find the problematic one. It might be a bug in i965 that was just uncovered and fixing it might be non-trivial. For example, set_max_gl_versions in i965 doesn't allow creating GL 4.6 contexts directly, but there might be more. T

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes
The FC suffix does not help. We are testing openglcts from opengl-cts-4.6.0 branch of gitlab.khronos.org:Tracker/vk-gl-cts.git: d6144a989 Fix attribute mapping in enhanced layouts tests for input arrays MESA_GLES_VERSION_OVERRIDE=3.2 MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVER

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Marek Olšák
This should work (I added "FC" at the end): MESA_GLSL_VERSION_OVERRIDE=460 MESA_GL_VERSION_OVERRIDE=4.6FC Marek On Wed, Nov 1, 2017 at 11:16 PM, Mark Janes wrote: > Mark Janes writes: > >> Marek Olšák writes: >> >>> Hi Mark, >>> >>> Can you try the attached patches instead? >> >> After talkin

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes
Mark Janes writes: > Marek Olšák writes: > >> Hi Mark, >> >> Can you try the attached patches instead? > > After talking with Ken and Dylan, I realize that I missed a one-line > patch from your thread with my last test (Oct 25 patch to > intel_extensions.c). With that patch, there are no regres

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes
Marek Olšák writes: > Hi Mark, > > Can you try the attached patches instead? After talking with Ken and Dylan, I realize that I missed a one-line patch from your thread with my last test (Oct 25 patch to intel_extensions.c). With that patch, there are no regressions in CI. I'm testing the atta

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Marek Olšák
Hi Mark, Can you try the attached patches instead? Thanks, Marek On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes wrote: > Dylan Baker writes: > >> I haven't run the CTS tests, but both the deqp and the piglit test pass on my >> skl with Marek's patches applied. > > I must have tested with only the

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Mark Janes
Dylan Baker writes: > I haven't run the CTS tests, but both the deqp and the piglit test pass on my > skl with Marek's patches applied. I must have tested with only the patch 2 applied. Running with all three patches in the series, I see no piglit/deqp regressions. However, GLES CTS fails thou

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Dylan Baker
I haven't run the CTS tests, but both the deqp and the piglit test pass on my skl with Marek's patches applied. Dylan Quoting Marek Olšák (2017-10-31 18:16:51) > This is how I run piglit on i965: > WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm > piglit/bin/glinfo|head > GL_RENDERER =

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Marek Olšák
On Wed, Nov 1, 2017 at 6:56 PM, Dylan Baker wrote: > I'm asking a dumb question, but we always build with --enable-debug, are you > building with --enable-debug? Yes. If ctx->Version == 0, something is terribly wrong and the OpenGL driver should be non-functional. Marek _

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Dylan Baker
I'm asking a dumb question, but we always build with --enable-debug, are you building with --enable-debug? Dylan Quoting Marek Olšák (2017-10-31 18:16:51) > This is how I run piglit on i965: > WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm > piglit/bin/glinfo|head > GL_RENDERER = Mesa

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-31 Thread Marek Olšák
This is how I run piglit on i965: WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm piglit/bin/glinfo|head GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop Of course I have Radeon as my main GPU. Marek On Wed, Nov 1, 2017 at 12:52 AM, Mark Janes wrote: > No, please don't. We can't hav

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-31 Thread Mark Janes
No, please don't. We can't have thousands of failures added to CI. Dylan, can you double check this for Marek? I'm surprised that it doesn't reproduce for him. -Mark Marek Olšák writes: > I can't reproduce the issue on my IVB. How about I just push this and > you guys fix i965 when you have

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-31 Thread Marek Olšák
I can't reproduce the issue on my IVB. How about I just push this and you guys fix i965 when you have time? Marek On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes wrote: > That fixed many issues, but: > > On deqp EGL tests, we get: > > dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-26 Thread Mark Janes
That fixed many issues, but: On deqp EGL tests, we get: dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion `ctx->Version > 0' failed. On ES31 CTS tests: ES31-CTS.functional.texture.texture_buffer.render

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Dylan Baker
I've pushed it to our CI, I'll let you know tomorrow what it looks like Dylan Quoting Marek Olšák (2017-10-25 19:52:43) > Hi Dylan, > > Can you please add this and re-test? > > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/ > dri/i965/intel_extensions.c > index 21

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Marek Olšák
Hi Dylan, Can you please add this and re-test? diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 21cf632..4d17393 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++ b/src/mesa/drivers/dri/i965/intel_extensions.c @@ -178,7 +17

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Ilia Mirkin
On Sat, Oct 21, 2017 at 8:54 AM, Marek Olšák wrote: > From: Marek Olšák > > We already have piglit tests testing alpha, luminance, and intensity > formats. They were skipped by piglit until now. > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run > with the compat profi

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Dylan Baker
For list posterity, since my intel email isn't subscribed, There are a significant number of i965 regressions from

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Dylan Baker
I ran it through our CI and there do appear to be a fair number of regressions. The majority of the errors are in the ES 3.1 CTS (there are also a few in deqp ES 3.1) and have this as their error message: glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM I'm bisecting now, I'll update

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-25 Thread Marek Olšák
On Tue, Oct 24, 2017 at 6:30 PM, Emil Velikov wrote: > Hi Marek, > > On 21 October 2017 at 13:54, Marek Olšák wrote: >> From: Marek Olšák >> >> We already have piglit tests testing alpha, luminance, and intensity >> formats. They were skipped by piglit until now. >> >> Additionally, I'm enabling

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-24 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák > > We already have piglit tests testing alpha, luminance, and intensity > formats. They were skipped by piglit until now. > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run > with the compat profile. Reviewed-by: Eric Anholt

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-24 Thread Emil Velikov
Hi Marek, On 21 October 2017 at 13:54, Marek Olšák wrote: > From: Marek Olšák > > We already have piglit tests testing alpha, luminance, and intensity > formats. They were skipped by piglit until now. > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run > with the compa

[Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-21 Thread Marek Olšák
From: Marek Olšák We already have piglit tests testing alpha, luminance, and intensity formats. They were skipped by piglit until now. Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run with the compat profile. --- src/mapi/glapi/gen/apiexec.py| 12 +-