Re: [Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-16 Thread Connor Abbott
On Wed, Sep 16, 2015 at 8:25 AM, Rob Clark wrote: > From: Rob Clark > > Rename print_var_state to print_state, and stuff FILE ptr into the state > object. This avoids passing around an extra parameter everywhere. > > v2: even more extensive conversion.. use state *everywhere* instead of > FILE p

Re: [Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-16 Thread Iago Toral
Looks good, Reviewed-by: Iago Toral Quiroga On Wed, 2015-09-16 at 08:25 -0400, Rob Clark wrote: > From: Rob Clark > > Rename print_var_state to print_state, and stuff FILE ptr into the state > object. This avoids passing around an extra parameter everywhere. > > v2: even more extensive conve

[Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-16 Thread Rob Clark
From: Rob Clark Rename print_var_state to print_state, and stuff FILE ptr into the state object. This avoids passing around an extra parameter everywhere. v2: even more extensive conversion.. use state *everywhere* instead of FILE ptr, and convert nir_print_instr() to use state as well Signed-

Re: [Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-15 Thread Rob Clark
On Tue, Sep 15, 2015 at 9:50 PM, Connor Abbott wrote: > On Tue, Sep 15, 2015 at 9:42 PM, Rob Clark wrote: >> On Tue, Sep 15, 2015 at 8:48 PM, Connor Abbott wrote: >>> On Tue, Sep 15, 2015 at 7:33 PM, Rob Clark wrote: From: Rob Clark Rename print_var_state to print_state, and stu

Re: [Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-15 Thread Connor Abbott
On Tue, Sep 15, 2015 at 9:42 PM, Rob Clark wrote: > On Tue, Sep 15, 2015 at 8:48 PM, Connor Abbott wrote: >> On Tue, Sep 15, 2015 at 7:33 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Rename print_var_state to print_state, and stuff FILE ptr into the state >>> object. This avoids passing ar

Re: [Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-15 Thread Rob Clark
On Tue, Sep 15, 2015 at 8:48 PM, Connor Abbott wrote: > On Tue, Sep 15, 2015 at 7:33 PM, Rob Clark wrote: >> From: Rob Clark >> >> Rename print_var_state to print_state, and stuff FILE ptr into the state >> object. This avoids passing around an extra parameter everywhere. >> >> Signed-off-by: R

Re: [Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-15 Thread Connor Abbott
On Tue, Sep 15, 2015 at 7:33 PM, Rob Clark wrote: > From: Rob Clark > > Rename print_var_state to print_state, and stuff FILE ptr into the state > object. This avoids passing around an extra parameter everywhere. > > Signed-off-by: Rob Clark > --- > src/glsl/nir/nir_print.c | 95 > +++

[Mesa-dev] [PATCH 2/3] nir/print: bit of state refactoring

2015-09-15 Thread Rob Clark
From: Rob Clark Rename print_var_state to print_state, and stuff FILE ptr into the state object. This avoids passing around an extra parameter everywhere. Signed-off-by: Rob Clark --- src/glsl/nir/nir_print.c | 95 +++- 1 file changed, 54 insertions