Re: [Mesa-dev] [PATCH 2/4] common: Correct PBO 2D_ARRAY handling.

2015-02-20 Thread Laura Ekstrand
There needs to be some corresponding Piglit test to guarantee that skip pixels is really a problem here. Otherwise, I'm flying blind trying to fix it. On Fri, Feb 20, 2015 at 5:04 PM, Jason Ekstrand wrote: > This is mostly correct and it's a good solution. The only problem is that > it doesn't

Re: [Mesa-dev] [PATCH 2/4] common: Correct PBO 2D_ARRAY handling.

2015-02-20 Thread Jason Ekstrand
This is mostly correct and it's a good solution. The only problem is that it doesn't handle the skipRows packing property properly. This property tells the driver the stride (in rows) between image planes in the data. Most of the places where depth is used below, we should be using the stride (in

[Mesa-dev] [PATCH 2/4] common: Correct PBO 2D_ARRAY handling.

2015-02-20 Thread Laura Ekstrand
Changes PBO uploads and downloads to use a tall (height * depth) 2D texture for blitting. This fixes the bug where 2D_ARRAY, 3D, and CUBE_MAP_ARRAY textures are not properly uploaded and downloaded. --- src/mesa/drivers/common/meta_tex_subimage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del