Re: [Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-20 Thread Chad Versace
On Wed 19 Nov 2014, Kenneth Graunke wrote: On Wednesday, November 19, 2014 02:13:03 PM Ian Romanick wrote: On 11/18/2014 09:11 PM, Chad Versace wrote: This patch should diminish the likelihood of pointer arithmetic overflow bugs, like the one fixed by b69c7c5dac. Change the type of

Re: [Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-20 Thread Ian Romanick
On 11/19/2014 09:18 PM, Kenneth Graunke wrote: On Wednesday, November 19, 2014 02:13:03 PM Ian Romanick wrote: On 11/18/2014 09:11 PM, Chad Versace wrote: This patch should diminish the likelihood of pointer arithmetic overflow bugs, like the one fixed by b69c7c5dac. Change the type of

[Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-19 Thread Chad Versace
This patch should diminish the likelihood of pointer arithmetic overflow bugs, like the one fixed by b69c7c5dac. Change the type of parameter 'out_stride' from int to ptrdiff_t. The logic is that if you call intel_miptree_map() and use the value of 'out_stride', then you must be doing pointer

[Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-19 Thread Chad Versace
This patch should diminish the likelihood of pointer arithmetic overflow bugs, like the one fixed by b69c7c5dac. Change the type of parameter 'out_stride' from int to ptrdiff_t. The logic is that if you call intel_miptree_map() and use the value of 'out_stride', then you must be doing pointer

Re: [Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-19 Thread Ian Romanick
On 11/18/2014 09:11 PM, Chad Versace wrote: This patch should diminish the likelihood of pointer arithmetic overflow bugs, like the one fixed by b69c7c5dac. Change the type of parameter 'out_stride' from int to ptrdiff_t. The logic is that if you call intel_miptree_map() and use the value of

Re: [Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-19 Thread Kenneth Graunke
On Wednesday, November 19, 2014 02:13:03 PM Ian Romanick wrote: On 11/18/2014 09:11 PM, Chad Versace wrote: This patch should diminish the likelihood of pointer arithmetic overflow bugs, like the one fixed by b69c7c5dac. Change the type of parameter 'out_stride' from int to ptrdiff_t.

Re: [Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-19 Thread Ben Widawsky
On Wed, Nov 19, 2014 at 09:18:54PM -0800, Kenneth Graunke wrote: On Wednesday, November 19, 2014 02:13:03 PM Ian Romanick wrote: On 11/18/2014 09:11 PM, Chad Versace wrote: This patch should diminish the likelihood of pointer arithmetic overflow bugs, like the one fixed by b69c7c5dac.

Re: [Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

2014-11-19 Thread Ben Widawsky
On Wed, Nov 19, 2014 at 10:40:56PM -0800, Ben Widawsky wrote: On Wed, Nov 19, 2014 at 09:18:54PM -0800, Kenneth Graunke wrote: On Wednesday, November 19, 2014 02:13:03 PM Ian Romanick wrote: On 11/18/2014 09:11 PM, Chad Versace wrote: This patch should diminish the likelihood of pointer