Re: [Mesa-dev] [PATCH 2/4] spirv: Add support for fuction arguments of type image and sampler

2017-10-06 Thread Samuel Iglesias Gonsálvez
On Fri, 2017-10-06 at 06:22 -0700, Jason Ekstrand wrote: > On Fri, Oct 6, 2017 at 2:36 AM, Samuel Iglesias Gonsálvez igalia.com> wrote: > > These arguments are actually variables, not pointers. This is > > allowed > > by SPIR-V spec but the support was missing. > > In SPIR-V, even

Re: [Mesa-dev] [PATCH 2/4] spirv: Add support for fuction arguments of type image and sampler

2017-10-06 Thread Jason Ekstrand
On Fri, Oct 6, 2017 at 2:36 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > These arguments are actually variables, not pointers. This is allowed > by SPIR-V spec but the support was missing. > In SPIR-V, even OpVariable returns a pointer. I think you could probably save yourself

[Mesa-dev] [PATCH 2/4] spirv: Add support for fuction arguments of type image and sampler

2017-10-06 Thread Samuel Iglesias Gonsálvez
These arguments are actually variables, not pointers. This is allowed by SPIR-V spec but the support was missing. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_cfg.c | 13 + src/compiler/spirv/vtn_private.h | 5 + 2 files changed,