Re: [Mesa-dev] [PATCH 2/5] glsl: Remove bonus tree walking in opt_constant_folding().

2016-05-09 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > It looks like this was missed when converting opt_constant_folding() > from a hierarchical visitor to an rvalue visitor in 6606fde3. > > ir_rvalue_visitor already processes values on the way back up the tre

[Mesa-dev] [PATCH 2/5] glsl: Remove bonus tree walking in opt_constant_folding().

2016-05-08 Thread Kenneth Graunke
It looks like this was missed when converting opt_constant_folding() from a hierarchical visitor to an rvalue visitor in 6606fde3. ir_rvalue_visitor already processes values on the way back up the tree, so we will have already visited every child node. There's no point in doing it again. No chan