Jason Ekstrand ja...@jlekstrand.net writes:
+ texImages[0] = _mesa_select_tex_image(ctx, texObj, texObj-Target,
level);
Do you want this inside an else block?
I think it's quite a common idiom in Mesa to handle the special cases as
a series of if-statements with a return upfront before
Ian Romanick i...@freedesktop.org writes:
Are there potentially cases where the first clear_tex_image could
succeed but the second fail? If so, then this is no good. If a GL call
generates an error (other than GL_NO_MEMORY), it is supposed to be as
though nothing happened.
Urgh, yes,
On Tue, Jul 1, 2014 at 10:09 AM, Neil Roberts n...@linux.intel.com wrote:
Jason Ekstrand ja...@jlekstrand.net writes:
+ texImages[0] = _mesa_select_tex_image(ctx, texObj, texObj-Target,
level);
Do you want this inside an else block?
I think it's quite a common idiom in Mesa to
On Fri, Jun 13, 2014 at 5:59 PM, Neil Roberts n...@linux.intel.com wrote:
This adds the driver entry point for glClearTexSubImage and fills in the
_mesa_ClearTexImage and _mesa_ClearTexSubImage functions that call it.
---
src/mesa/main/dd.h | 14 +++
src/mesa/main/teximage.c | 241
On 06/13/2014 05:59 PM, Neil Roberts wrote:
This adds the driver entry point for glClearTexSubImage and fills in the
_mesa_ClearTexImage and _mesa_ClearTexSubImage functions that call it.
---
src/mesa/main/dd.h | 14 +++
src/mesa/main/teximage.c | 241
Ilia Mirkin imir...@alum.mit.edu writes:
+ if (ctx-Version = 30 || ctx-Extensions.EXT_texture_integer) {
Just ctx-Extensions.EXT_texture_integer should be enough here, no?
I'm reluctant to change this because every other place in the code that
checks for integer textures does it in the same
The presence of EXT_texture_integer implies EXT_gpu_shader4, so I
added ctx-Version = 30 || ctx-Extensions.EXT_texture_integer
everywhere to allow drivers to disable EXT_texture_integer but not
lose integer textures from GL 3.0.
Marek
On Mon, Jun 16, 2014 at 12:49 PM, Neil Roberts
On Fri, Jun 13, 2014 at 8:59 PM, Neil Roberts n...@linux.intel.com wrote:
This adds the driver entry point for glClearTexSubImage and fills in the
_mesa_ClearTexImage and _mesa_ClearTexSubImage functions that call it.
---
src/mesa/main/dd.h | 14 +++
src/mesa/main/teximage.c | 241
