Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-19 Thread Jason Ekstrand
In general, I think I like this. The CPP was fine and I in general prefer it when practical but this is probably justified in light of the constant folding stuff. Good work on making of look very similar to the old nir_opcodes.h. Only 1 comment below. On Jan 16, 2015 3:46 PM, "Connor Abbott" w

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-17 Thread ahmad
thats make sense. regards. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-17 Thread Dylan Baker
On Saturday, January 17, 2015 01:09:45 PM Connor Abbott wrote: > On Sat, Jan 17, 2015 at 11:42 AM, ahmad wrote: > > hi. > > > > "#! /usr/bin/env python" corresponds python 3.x series for some major > > distro (arch,fedora ...) and python 2.x for some others. > > > > python 2.x and python 3.x are

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-17 Thread Connor Abbott
On Sat, Jan 17, 2015 at 11:42 AM, ahmad wrote: > hi. > > "#! /usr/bin/env python" corresponds python 3.x series for some major distro > (arch,fedora ...) and python 2.x for some others. > > python 2.x and python 3.x are not source compatible each other. > > python 3.x not contains "xrange" funci

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-17 Thread ahmad
hi. "#! /usr/bin/env python" corresponds python 3.x series for some major distro (arch,fedora ...) and python 2.x for some others. python 2.x and python 3.x are not source compatible each other. python 3.x not contains "xrange" funcion anymore. range vs xrange only meaningfull for python 2.x

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-16 Thread Connor Abbott
On Fri, Jan 16, 2015 at 10:48 PM, Dylan Baker wrote: > On Friday, January 16, 2015 10:18:43 PM Connor Abbott wrote: >> Hi Dylan, >> >> On Fri, Jan 16, 2015 at 7:01 PM, Dylan Baker wrote: >> > Hi Conner, I have a couple of things you should change, and a suggestion >> > for you below, hopefully it

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-16 Thread Dylan Baker
On Friday, January 16, 2015 10:18:43 PM Connor Abbott wrote: > Hi Dylan, > > On Fri, Jan 16, 2015 at 7:01 PM, Dylan Baker wrote: > > Hi Conner, I have a couple of things you should change, and a suggestion > > for you below, hopefully it all makes sense. > > > > On Friday, January 16, 2015 04:46:

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-16 Thread Connor Abbott
Hi Dylan, On Fri, Jan 16, 2015 at 7:01 PM, Dylan Baker wrote: > Hi Conner, I have a couple of things you should change, and a suggestion > for you below, hopefully it all makes sense. > > On Friday, January 16, 2015 04:46:07 PM Connor Abbott wrote: >> Before, we used a system where a file, nir_op

Re: [Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-16 Thread Dylan Baker
Hi Conner, I have a couple of things you should change, and a suggestion for you below, hopefully it all makes sense. On Friday, January 16, 2015 04:46:07 PM Connor Abbott wrote: > Before, we used a system where a file, nir_opcodes.h, defined some macros that > were included to generate the enum v

[Mesa-dev] [PATCH 2/5] nir: use Python to autogenerate opcode information

2015-01-16 Thread Connor Abbott
Before, we used a system where a file, nir_opcodes.h, defined some macros that were included to generate the enum values and the nir_op_infos structure. This worked pretty well, but for development the error messages were never very useful, Python tools couldn't understand the opcode list, and it w