Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

2014-03-15 Thread Kenneth Graunke
On 03/14/2014 11:40 AM, Pohjolainen, Topi wrote: > On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: >> Previously, both move_uniform_array_access_to_pull_constants() and >> setup_pull_constants() maintained stack-local arrays with this >> information. Storing this information will

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

2014-03-15 Thread Pohjolainen, Topi
On Fri, Mar 14, 2014 at 01:39:05PM -0700, Kenneth Graunke wrote: > On 03/14/2014 11:40 AM, Pohjolainen, Topi wrote: > > On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: > >> Previously, both move_uniform_array_access_to_pull_constants() and > >> setup_pull_constants() maintained sta

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

2014-03-14 Thread Pohjolainen, Topi
On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: > Previously, both move_uniform_array_access_to_pull_constants() and > setup_pull_constants() maintained stack-local arrays with this > information. Storing this information will allow it to be used from > multiple functions, allowin

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

2014-03-14 Thread Pohjolainen, Topi
On Thu, Mar 13, 2014 at 08:46:24PM -0700, Kenneth Graunke wrote: > On 03/13/2014 05:55 PM, Pohjolainen, Topi wrote: > > On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: > >> Previously, both move_uniform_array_access_to_pull_constants() and > >> setup_pull_constants() maintained sta

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

2014-03-13 Thread Kenneth Graunke
On 03/13/2014 05:55 PM, Pohjolainen, Topi wrote: > On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: >> Previously, both move_uniform_array_access_to_pull_constants() and >> setup_pull_constants() maintained stack-local arrays with this >> information. Storing this information will

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

2014-03-13 Thread Pohjolainen, Topi
On Tue, Mar 11, 2014 at 11:48:51PM -0700, Kenneth Graunke wrote: > Previously, both move_uniform_array_access_to_pull_constants() and > setup_pull_constants() maintained stack-local arrays with this > information. Storing this information will allow it to be used from > multiple functions, allowin

[Mesa-dev] [PATCH 2/7] i965/fs: Save push constant location information.

2014-03-11 Thread Kenneth Graunke
Previously, both move_uniform_array_access_to_pull_constants() and setup_pull_constants() maintained stack-local arrays with this information. Storing this information will allow it to be used from multiple functions, allowing us to split and move code around. We'll also eventually want to pass p