Re: [Mesa-dev] [PATCH 2/7] i965: Move program cache printing to brw_program_cache.c.

2017-01-17 Thread Kenneth Graunke
On Tuesday, January 17, 2017 8:43:28 AM PST Eduardo Lima Mitev wrote: > If there is no plan to use brw_print_program_cache elsewhere, I would > rather keep it a static method where it is used. In general, I prefer > not polluting header files. Not a big deal anyway; feel free to ignore > the

Re: [Mesa-dev] [PATCH 2/7] i965: Move program cache printing to brw_program_cache.c.

2017-01-16 Thread Eduardo Lima Mitev
If there is no plan to use brw_print_program_cache elsewhere, I would rather keep it a static method where it is used. In general, I prefer not polluting header files. Not a big deal anyway; feel free to ignore the comment. Reviewed-by: Eduardo Lima Mitev On 01/17/2017 08:14

[Mesa-dev] [PATCH 2/7] i965: Move program cache printing to brw_program_cache.c.

2017-01-16 Thread Kenneth Graunke
It makes sense to put a function which prints out the entire contents of the program cache in the file that implements the program cache. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_program_cache.c | 46 +