[Mesa-dev] [PATCH 2/8] util: Add tests for the string buffer

2017-08-29 Thread Thomas Helland
More tests could probably be added, but this should cover concatenation, resizing, clearing, formatted printing, and checking the length, so it should be quite complete. V2: Address review feedback from Timothy, plus fixes - Use a large enough char array - Actually test the formatted appendi

Re: [Mesa-dev] [PATCH 2/8] util: Add tests for the string buffer

2017-09-06 Thread Nicolai Hähnle
On 29.08.2017 21:56, Thomas Helland wrote: More tests could probably be added, but this should cover concatenation, resizing, clearing, formatted printing, and checking the length, so it should be quite complete. V2: Address review feedback from Timothy, plus fixes - Use a large enough char

Re: [Mesa-dev] [PATCH 2/8] util: Add tests for the string buffer

2017-08-30 Thread Emil Velikov
On 29 August 2017 at 20:56, Thomas Helland wrote: > -SUBDIRS = xmlpool . tests/hash_table > +SUBDIRS = . tests/hash_table \ > + . tests/string_buffer > xmlpool disappeared here and current directory (.) is seen multiple times. To minimise this kind of issues I tend to use ( since the cli