Re: [Mesa-dev] [PATCH 2/9] nir: insert ssa_undef instructions when cleanup up defs/uses

2015-05-08 Thread Connor Abbott
On Sat, May 9, 2015 at 1:52 AM, Jason Ekstrand wrote: > On Fri, May 8, 2015 at 10:03 PM, Connor Abbott wrote: >> The point of cleanup_defs_uses() is to make an instruction safe to >> remove by removing any references that the rest of the shader may have >> to it. Previously, it was handling regis

Re: [Mesa-dev] [PATCH 2/9] nir: insert ssa_undef instructions when cleanup up defs/uses

2015-05-08 Thread Jason Ekstrand
On Fri, May 8, 2015 at 10:03 PM, Connor Abbott wrote: > The point of cleanup_defs_uses() is to make an instruction safe to > remove by removing any references that the rest of the shader may have > to it. Previously, it was handling register use/def sets and removing > the instruction from the use

[Mesa-dev] [PATCH 2/9] nir: insert ssa_undef instructions when cleanup up defs/uses

2015-05-08 Thread Connor Abbott
The point of cleanup_defs_uses() is to make an instruction safe to remove by removing any references that the rest of the shader may have to it. Previously, it was handling register use/def sets and removing the instruction from the use sets of any SSA sources it had, but if the instruction defined