Re: [Mesa-dev] [PATCH 20/22] i965/gen7: merge defines for 3DSTATE{VS, GS, WM} dword 2

2013-08-29 Thread Paul Berry
On 28 August 2013 20:16, Kenneth Graunke wrote: > On 08/26/2013 03:12 PM, Paul Berry wrote: > >> Dword 2 of all 3DSTATE commands is the same, so there's no need tohave >> > > Well, not -all- 3DSTATE commands...just these :) > > It's weird that you decided to share the bits for 3DSTATE_VS, 3DSTATE

Re: [Mesa-dev] [PATCH 20/22] i965/gen7: merge defines for 3DSTATE{VS, GS, WM} dword 2

2013-08-28 Thread Kenneth Graunke
On 08/26/2013 03:12 PM, Paul Berry wrote: Dword 2 of all 3DSTATE commands is the same, so there's no need tohave Well, not -all- 3DSTATE commands...just these :) It's weird that you decided to share the bits for 3DSTATE_VS, 3DSTATE_GS, and 3DSTATE_WM on SNB, but not GEN7_PS_* for 3DSTATE_PS o

[Mesa-dev] [PATCH 20/22] i965/gen7: merge defines for 3DSTATE{VS, GS, WM} dword 2

2013-08-26 Thread Paul Berry
Dword 2 of all 3DSTATE commands is the same, so there's no need tohave separate defines for it. This will allow us to unify some of the state setup code between VS and GS. --- src/mesa/drivers/dri/i965/brw_defines.h | 30 +- src/mesa/drivers/dri/i965/gen6_blorp.cpp