Re: [Mesa-dev] [PATCH 21/22] i965: Setup glsl uniforms by index rather than name matching

2018-05-03 Thread Timothy Arceri
On 03/05/18 22:50, Neil Roberts wrote: Thanks for the feedback. I’ve implemented your suggestion as the top two patches on a branch here: https://github.com/Igalia/mesa/tree/nroberts/count-uniform-storage It also fixes a slight bug that it wasn’t passing down the uniform_storage_locs argument

Re: [Mesa-dev] [PATCH 21/22] i965: Setup glsl uniforms by index rather than name matching

2018-05-03 Thread Neil Roberts
Thanks for the feedback. I’ve implemented your suggestion as the top two patches on a branch here: https://github.com/Igalia/mesa/tree/nroberts/count-uniform-storage It also fixes a slight bug that it wasn’t passing down the uniform_storage_locs argument into the recursion. However I think my

Re: [Mesa-dev] [PATCH 21/22] i965: Setup glsl uniforms by index rather than name matching

2018-05-03 Thread Timothy Arceri
On 18/04/18 00:36, Alejandro Piñeiro wrote: From: Neil Roberts Previously when setting up a uniform it would try to walk the uniform storage slots and find one that matches the name of the given variable. However, each variable already has a location which is an index into

[Mesa-dev] [PATCH 21/22] i965: Setup glsl uniforms by index rather than name matching

2018-04-17 Thread Alejandro Piñeiro
From: Neil Roberts Previously when setting up a uniform it would try to walk the uniform storage slots and find one that matches the name of the given variable. However, each variable already has a location which is an index into the UniformStorage array so we can just