Re: [Mesa-dev] [PATCH 3/3] egl/wayland: unify dri2_wl_create_surface implementations

2016-11-11 Thread Emil Velikov
On 11 November 2016 at 17:19, Daniel Stone wrote: > Hi, > > On 11 November 2016 at 16:45, Emil Velikov wrote: >> @@ -174,14 +172,24 @@ dri2_wl_create_surface(_EGLDriver *drv, _EGLDisplay >> *disp, >> config = dri2_get_dri_config(dri2_conf,

Re: [Mesa-dev] [PATCH 3/3] egl/wayland: unify dri2_wl_create_surface implementations

2016-11-11 Thread Daniel Stone
Hi, On 11 November 2016 at 16:45, Emil Velikov wrote: > @@ -174,14 +172,24 @@ dri2_wl_create_surface(_EGLDriver *drv, _EGLDisplay > *disp, > config = dri2_get_dri_config(dri2_conf, EGL_WINDOW_BIT, > dri2_surf->base.GLColorspace); >

[Mesa-dev] [PATCH 3/3] egl/wayland: unify dri2_wl_create_surface implementations

2016-11-11 Thread Emil Velikov
From: Emil Velikov Rather than having two almost identical codepaths (one for HW/wl_drm and another for SW/wl_shm), just factorise and reuse in both places. Signed-off-by: Emil Velikov --- Another fine example of useless duplication that