Re: [Mesa-dev] [PATCH 3/3] gallivm: honor explicit derivatives values for cube maps.

2013-04-03 Thread Jose Fonseca
I only had time to skim through your changes but the series looks great, Roland. If it's not too much trouble, could you please add a piglit test for explicit cube derivatives? Also, please confirm there are no piglit regressions. Jose - Original Message - From: Roland Scheidegger

[Mesa-dev] [PATCH 3/3] gallivm: honor explicit derivatives values for cube maps.

2013-04-02 Thread sroland
From: Roland Scheidegger srol...@vmware.com This is trivial now, though need to make sure we pass all the necessary derivative values (which is 3 each for ddx/ddy not 2). Untested (no piglit test) however since the transform works the same as implicit derivatives this should probably work