Re: [Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

2015-09-28 Thread Timothy Arceri
On Mon, 2015-09-28 at 12:59 +0200, Iago Toral Quiroga wrote: > The comment says that it should be impossible for decl_type to be > NULL > here, so don't try to handle the case where it is, simply add an > assert. > > > > > CID 1324977: Null pointer dereferences (FORWARD_NULL) > > > > Com

Re: [Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

2015-09-28 Thread Iago Toral
CCing Ian... On Mon, 2015-09-28 at 13:02 +0200, Iago Toral wrote: > Ian, you wrote the original code, so you might want to have a look at > this one just in case I missed something even if piglit does not > complain. In any case, I guess that either the code or the comment > should be fixed. > >

Re: [Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

2015-09-28 Thread Iago Toral
Ian, you wrote the original code, so you might want to have a look at this one just in case I missed something even if piglit does not complain. In any case, I guess that either the code or the comment should be fixed. Iago On Mon, 2015-09-28 at 12:59 +0200, Iago Toral Quiroga wrote: > The commen

[Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

2015-09-28 Thread Iago Toral Quiroga
The comment says that it should be impossible for decl_type to be NULL here, so don't try to handle the case where it is, simply add an assert. >>> CID 1324977: Null pointer dereferences (FORWARD_NULL) >>> Comparing "decl_type" to null implies that "decl_type" might be null. No piglit r