[Mesa-dev] [PATCH 3/3] mesa: Fix string_to_uint_map-iterate to return same numbers from put()

2014-12-04 Thread Carl Worth
There is an internal implementation detail that the hash table underlying the struct string_to_uint_map stores each value internally as (value+1). The user needn't be very concerned with this (other than knowing that a value of UINT_MAX cannot be stored) since put() adds 1 and get() subtracts 1.

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix string_to_uint_map-iterate to return same numbers from put()

2014-12-04 Thread Ian Romanick
On 12/04/2014 02:00 PM, Carl Worth wrote: There is an internal implementation detail that the hash table underlying the struct string_to_uint_map stores each value internally as (value+1). The user needn't be very concerned with this (other than knowing that a value of UINT_MAX cannot be

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix string_to_uint_map-iterate to return same numbers from put()

2014-12-04 Thread Carl Worth
On Thu, Dec 04 2014, Ian Romanick wrote: Should this just get squashed with the previous commit? Yes. I only hesitated because I wrote the second and not the first, (so I didn't want to lose authorship in the history). But it's not useful to have an iterate in the history that actually does the

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix string_to_uint_map-iterate to return same numbers from put()

2014-12-04 Thread Tapani Pälli
Yep, my implementation leaked this detail to be handled by the caller. This looks nicer as it's all isolated in the class. Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 12/05/2014 12:00 AM, Carl Worth wrote: There is an internal implementation detail that the hash table underlying the