Re: [Mesa-dev] [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware

2016-06-22 Thread Zhang, Boyuan
OK, so I added get parameters call for each firmware versions, and moved all the value assignments to firmware specific file. As a result, changes made for specific version won't affect other version. For future firmware verison, we still can use the same structure but assign different values in

Re: [Mesa-dev] [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware

2016-06-22 Thread Christian König
Am 22.06.2016 um 17:43 schrieb Zhang, Boyuan: We should write the encode structure directly without the use of the RVCE_CS() macros. Otherwise all of that doesn't make much sense and is just another layer of abstraction. Different from UVD where firmware takes the address of the IB structure,

Re: [Mesa-dev] [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware

2016-06-22 Thread Zhang, Boyuan
> We should write the encode structure directly without the use of the > RVCE_CS() macros. > > Otherwise all of that doesn't make much sense and is just another layer of > abstraction. Different from UVD where firmware takes the address of the IB structure, VCE firmware directly takes the value

Re: [Mesa-dev] [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware

2016-06-22 Thread Christian König
Am 21.06.2016 um 16:50 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce.c| 171 +++ src/gallium/drivers/radeon/radeon_vce.h| 1 + src/gallium/drivers/radeon/radeon_vce_52.c | 447 +++-- 3 files changed, 533

[Mesa-dev] [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware

2016-06-21 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce.c| 171 +++ src/gallium/drivers/radeon/radeon_vce.h| 1 + src/gallium/drivers/radeon/radeon_vce_52.c | 447 +++-- 3 files changed, 533 insertions(+), 86 deletions(-) diff --git a/src/g