Re: [Mesa-dev] [PATCH 3/3] spirv: Allow OpPtrAccessChain for block indices

2017-12-05 Thread Kristian Høgsberg
On Thu, Nov 30, 2017 at 9:15 PM, Jason Ekstrand wrote: > After talking with Kristian a bit on IRC, I think there is a bit more > explanation needed. I would be happy to add something like this to the > commit message or as a comment upon request. > > There is an interesting

Re: [Mesa-dev] [PATCH 3/3] spirv: Allow OpPtrAccessChain for block indices

2017-11-30 Thread Jason Ekstrand
After talking with Kristian a bit on IRC, I think there is a bit more explanation needed. I would be happy to add something like this to the commit message or as a comment upon request. There is an interesting edge case in the variable pointers extension when you do an OpPtrAccessChain on a

[Mesa-dev] [PATCH 3/3] spirv: Allow OpPtrAccessChain for block indices

2017-11-30 Thread Jason Ekstrand
The SPIR-V spec is a bit underspecified when it comes to exactly how you're allowed to use OpPtrAccessChain and what it means in certain edge cases. In particular, what if the base pointer of the OpPtrAccessChain points to the base struct of an SSBO instead of an element in that SSBO. The