Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

yes please BR, -R On Fri, Jul 29, 2016 at 1:37 AM, Francesco Ansanelli wrote: > I did a test with: > > static struct ir3_shader_key key; > memset(, 0, sizeof(key)); > > both gcc and clang seems happy with it. > Let me know if you want me to send a patch. > > > 2016-07-29

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

I did a test with: static struct ir3_shader_key key; memset(, 0, sizeof(key)); both gcc and clang seems happy with it. Let me know if you want me to send a patch. 2016-07-29 1:53 GMT+02:00 Rob Clark : > On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring wrote:

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring wrote: > On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark wrote: >> tbh, I haven't used anything as ancient as 4.6 in a while.. these days >> I'm using 6.1 and even with 5.x I don't remember seeing that warning. > >

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark wrote: > tbh, I haven't used anything as ancient as 4.6 in a while.. these days > I'm using 6.1 and even with 5.x I don't remember seeing that warning. FWIW, clang 3.8 throws the warning too. Rob

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

tbh, I haven't used anything as ancient as 4.6 in a while.. these days I'm using 6.1 and even with 5.x I don't remember seeing that warning. Maybe we can just drop -Wmissing-field-initializers?? BR, -R On Thu, Jul 28, 2016 at 1:16 PM, Francesco Ansanelli wrote: > Hi, > >

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

Hi, with my version of the compiler: gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 and original code ({0}) I get: src/gallium/drivers/freedreno/ir3/ir3_shader.c:312:17: warning: missing braces around initializer [-Wmissing-braces] src/gallium/drivers/freedreno/ir3/ir3_shader.c:312:17: warning:

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 6:31 AM, Emil Velikov wrote: > On 28 July 2016 at 09:21, Eric Engestrom wrote: >> On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: >>> Hello, >>> >>> unluckily this didn't fix the warning... >>> I've

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On 28 July 2016 at 09:21, Eric Engestrom wrote: > On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: >> Hello, >> >> unluckily this didn't fix the warning... >> I've done some more compile testing and found this solution: >> >> - static struct

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: > Hello, > > unluckily this didn't fix the warning... > I've done some more compile testing and found this solution: > > - static struct ir3_shader_key key = {{0}}; > +static struct ir3_shader_key key = {{{0, 0, 0, 0, 0, 0, 0,

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

Hello, unluckily this didn't fix the warning... I've done some more compile testing and found this solution: - static struct ir3_shader_key key = {{0}}; +static struct ir3_shader_key key = {{{0, 0, 0, 0, 0, 0, 0, 0}}, 0, 0, 0, 0, 0, 0, 0, 0}; is this correct? Should I send a new patch? Cheers,

[Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

--- src/gallium/drivers/freedreno/ir3/ir3_shader.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_shader.c b/src/gallium/drivers/freedreno/ir3/ir3_shader.c index 9f39f9f..5d57c0b 100644 ---